-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix === for abstract Reset types #3979
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the function would infinitely recurse resulting in a stack overflow.
seldridge
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mergify bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
Previously, the function would infinitely recurse resulting in a stack overflow. (cherry picked from commit ea2d103) # Conflicts: # core/src/main/scala/chisel3/Data.scala
mergify bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
Previously, the function would infinitely recurse resulting in a stack overflow. (cherry picked from commit ea2d103)
mergify bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
Previously, the function would infinitely recurse resulting in a stack overflow. (cherry picked from commit ea2d103)
This was referenced Apr 9, 2024
chiselbot
pushed a commit
that referenced
this pull request
Apr 9, 2024
chiselbot
pushed a commit
that referenced
this pull request
Apr 9, 2024
chiselbot
pushed a commit
that referenced
this pull request
Apr 9, 2024
* Fix === for abstract Reset types (#3979) Previously, the function would infinitely recurse resulting in a stack overflow. (cherry picked from commit ea2d103) # Conflicts: # core/src/main/scala/chisel3/Data.scala * Resolve backport conflicts --------- Co-authored-by: Jack Koenig <koenig@sifive.com>
SpriteOvO
pushed a commit
that referenced
this pull request
Apr 20, 2024
Previously, the function would infinitely recurse resulting in a stack overflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
Previously, the function would infinitely recurse resulting in a stack overflow.
Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.